feat(ui): show reserved resources in topology view#27846
Draft
sevensolutions wants to merge 3 commits intohashicorp:mainfrom
Draft
feat(ui): show reserved resources in topology view#27846sevensolutions wants to merge 3 commits intohashicorp:mainfrom
sevensolutions wants to merge 3 commits intohashicorp:mainfrom
Conversation
Contributor
Author
|
Strange... something seems to be broken with your linter config. const cpuRemainder = {
x: cpuOffset * width + 0.5,
width: Math.max((1 - cpuReservedPercent) * width - cpuOffset * width, 0),
};
const memoryRemainder = {
x: memoryOffset * width + 0.5,
width: Math.max(
(1 - memoryReservedPercent) * width - memoryOffset * width,
0
),
};For whatever reason they need to be exactly formatted like this (notice the line breaks in Math.max). When i try to format both in the same way, the linter is unhappy. |
github-project-automation
Bot
moved this to Needs Triage
in Nomad - Community Issues Triage
Contributor
Author
|
I just saw this commit: bbc538e I will rework this PR soon and resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR shows reserved resources (CPU and Memory) of every node within the topology view and closes #10794.
Testing & Reproduction steps
Navigate to the Topology page eg. using the "topoSmall" mirage preset.
http://localhost:4200/ui/topology?mirage-scenario=topoSmall
You should see some nodes with orange bars at the end. It also has a tooltip showing the actual values.
Here is a screenshot:
Links
#10794
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
AI Disclosure
In this PR, i've used AI (Github Copilot CLI) for assistance. Mainly to understand the correct places and how Ember JS works. The tests have been written entirely by AI.
I've reviewed and understood every single line.